Support per-iteration CTF correction - #138
Open
amineuron wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi Amin, in principal I'd be happy to merge this in, but you need to give me some more explanation of the tests that you ran. When we tried this we never noticed a big difference with CTF turned on or off. What is the test that you ran? How did you validate? Did you compare against some ground truth or STA? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
apply_ctfto be overridden in eachiteration_settingsentry. The resolved value is used consistently for training reconstructions and alignment, and both phases report it in the log.CLIMP validation (7 tilt series): adaptive CTF on the final two iterations ran in 8:56:37 vs 9:38:26 with CTF throughout (7.2% faster). Local-warp RMS / trajectory roughness were 25.62 / 19.60 Å adaptive, 26.39 / 21.04 Å CTF-off, and 21.44 / 17.98 Å CTF-on.
Tests: 173 passed, 2 skipped.